tools: widen network DHCP configuration for EC2 Root FS #6023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernd
changed the title
tarasmadan
previously approved these changes
May 14, 2025
tarasmadan
reviewed
May 14, 2025
The current EC2/AL2023 root file system only works for systems using the Intel e1000 driver. Remove the match clause to support all potential network interfaces and allow fuzzing with other network interfaces (such as virtio-net). Signed-off-by: Bjoern Doebel <doebel@amazon.de>
auto-merge was automatically disabled
May 14, 2025 11:12
Head branch was pushed to by a user without write access
tarasmadan
approved these changes
May 14, 2025
bjoernd
added a commit
to bjoernd/syzkaller
that referenced
this pull request
May 26, 2025
In a previous change (google#6023) we made a simplification, assuming that a non-existent Match section in systemd networkd's config would allow DHCP for any network interface. After more testing this turns out to be incorrect and we really only get an IP via DHCP with an explicit broad Name regex. Signed-off-by: Bjoern Doebel <doebel@amazon.de>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 26, 2025
In a previous change (#6023) we made a simplification, assuming that a non-existent Match section in systemd networkd's config would allow DHCP for any network interface. After more testing this turns out to be incorrect and we really only get an IP via DHCP with an explicit broad Name regex. Signed-off-by: Bjoern Doebel <doebel@amazon.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current EC2/AL2023 root file system only works for systems using the Intel e1000 driver. Extend the configuration to cover all potential network interfaces in order to allow fuzzing with other network interfaces (such as virtio-net).
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md